Performance improvements - #54
Merged
Merged
Conversation
…s usage in `bindWide` more efficient
…each path with a provided role and source
…athsByPathRole`, and by making the initialization part faster
…cope graph lookups for unused definitions with a unique identifier
… (using an auxiliary map of "prototypes")
…ter-bindwide Faster `bindWide`
…ter-lookupwide Faster `lookupWide`
…ments/faster-lookuppathswide
…ter-lookuppathswide Faster `lookupPathsWide`
…ter-resolvepaths Faster `resolvePaths`
…ter-definfo Faster `defInfo`
…ter-checkillegaloverloading Faster check for illegal overloading of unused definitions
…ter-reportunused Faster reporting of unused definitions
…fig-sorted-messages Configure if messages in `TModel`s should be sorted
sungshik
marked this pull request as ready for review
August 14, 2026 17:17
2 tasks
DavyLandman
added a commit
to usethesource/rascal
that referenced
this pull request
Aug 21, 2026
This PR introduces various performance improvements to the typechecker. Each improvement is contributed in a separate sub-PR. This PR is a companion of usethesource/typepal#54. Sub-PRs: - Improvements to typechecker: - #2833 - #2850 - #2853 - Improvements to interpreter: - #2858 Integration test [succeeds](https://github.com/usethesource/rascal-core-big-tests/actions/runs/32296970919). Anecdotally: - Roughly 1.7x faster than Rascal `v0.42.2` with Typepal `v0.16.6` - Roughly 1.4x faster than Rascal `main` (805dc0d) with Typepal `v0.17.0` (which has the performance improvements of usethesource/typepal#54 relative to `v0.16.6`) TODO: - [x] Remove scaffolding - [x] Await integration test
toinehartman
pushed a commit
to usethesource/rascal
that referenced
this pull request
Aug 25, 2026
This PR introduces various performance improvements to the typechecker. Each improvement is contributed in a separate sub-PR. This PR is a companion of usethesource/typepal#54. Sub-PRs: - Improvements to typechecker: - #2833 - #2850 - #2853 - Improvements to interpreter: - #2858 Integration test [succeeds](https://github.com/usethesource/rascal-core-big-tests/actions/runs/32296970919). Anecdotally: - Roughly 1.7x faster than Rascal `v0.42.2` with Typepal `v0.16.6` - Roughly 1.4x faster than Rascal `main` (805dc0d) with Typepal `v0.17.0` (which has the performance improvements of usethesource/typepal#54 relative to `v0.16.6`) TODO: - [x] Remove scaffolding - [x] Await integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces various performance improvements. Each improvement is contributed in a separate sub-PR.
Sub-PRs:
ConfigurableScopeGraph:bindWide#55lookupWide#56lookupPathsWide#57Solver:TModels should be sorted #58resolvePaths#59defInfo#62Integration test succeeds:
main: https://github.com/usethesource/rascal-core-big-tests/actions/runs/31808803232 -- roughly 1.5x fastermainlater): https://github.com/usethesource/rascal-core-big-tests/actions/runs/31808851949 -- roughly 2x fasterTODO:
SetSeparate issue: Delay computation of suggestions for unbound names? #64enableErrorFixestofalse?